Fix address widget labels for countries with mixed subdivision types#2931
Open
Lunga001 wants to merge 6 commits into
Open
Fix address widget labels for countries with mixed subdivision types#2931Lunga001 wants to merge 6 commits into
Lunga001 wants to merge 6 commits into
Conversation
ramonski
requested changes
Jun 16, 2026
ramonski
left a comment
ramonski
left a comment
Contributor
There was a problem hiding this comment.
Two minor things that would be nice to tackle in this PR.
Alsom resolve the conflicts please
| label = _("State") | ||
| if subdivisions: | ||
| label = _(subdivisions[0].type) | ||
| label = geo.get_subdivision_type(subdivisions, _("State")) |
Contributor
There was a problem hiding this comment.
Please change to _(u"label_subdivision_state", default=u"State") to not clash with the workflow state
| label = _("District") | ||
| if subdivisions: | ||
| label = _(subdivisions[0].type) | ||
| label = geo.get_subdivision_type(subdivisions, _("District")) |
Contributor
There was a problem hiding this comment.
Same here: _(u"label_subdivision_district", default=u"District")
Contributor
Author
|
Thank you @ramonski I've made the changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses
Linked issue: #2930
Current behavior before PR
The address widget may display two fields labelled "City" when the
selected country is Zimbabwe.
Desired behavior after PR is merged
The first-level subdivision field should be labelled appropriately
--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.