Draft
Fix Applications.Filter(Async) methods sending incorrect JSON body format#85
Conversation
Author
|
@seiggy 👋 This repository doesn't have Copilot instructions. With Copilot instructions, I can understand the repository better, work faster and produce higher quality PRs. I can generate a .github/copilot-instructions.md file for you automatically. Click here to open a pre-filled issue and assign it to me. I'll write the instructions, and then tag you for review. |
…wrapper Co-authored-by: seiggy <1055990+seiggy@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Applications.Filter(Async) sends wrong JSON body
Fix Applications.Filter(Async) methods sending incorrect JSON body format
Aug 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Applications.FilterandApplications.FilterAsyncmethods were sending an incorrectly formatted JSON body to the ARI server, which prevented event filtering from working properly.Problem
When calling these methods with a filter object like:
The library was sending:
{"filter":{"allowed":[{"type":"ChannelCreated"}]}}But according to the Asterisk ARI documentation, the expected format should be:
{"allowed":[{"type":"ChannelCreated"}]}This caused the event filter to be ignored, and ARI would continue sending all events regardless of the filter configuration.
Solution
Removed the unnecessary wrapper object from both methods. Changed:
To:
This ensures the filter object is serialized directly as the root JSON object, matching the expected ARI API format.
Testing
allowedanddisallowedarrays work correctlyFixes #82.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.