Skip to content
This repository was archived by the owner on Dec 19, 2025. It is now read-only.

fix: #142 raw literal with backslashes becomes "unescaped"#143

Open
dim0xff wants to merge 3 commits into
segmentio:masterfrom
dim0xff:bug/raw-literal-backslash
Open

fix: #142 raw literal with backslashes becomes "unescaped"#143
dim0xff wants to merge 3 commits into
segmentio:masterfrom
dim0xff:bug/raw-literal-backslash

Conversation

@dim0xff

@dim0xff dim0xff commented Aug 11, 2024

Copy link
Copy Markdown

fix #142

@ccoVeille ccoVeille left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see no tests updated, wasn't any?

Comment thread tags.go Outdated
@dim0xff

dim0xff commented Aug 11, 2024

Copy link
Copy Markdown
Author

I see no tests updated, wasn't any?

@ccoVeille I added test to _fixtures/struct_tags.go and test expectation to _fixtures/struct_tags__exp.go

Fixtures are being tested via shortener_test.go

@ccoVeille

Copy link
Copy Markdown

Oh that's right. I expected the tests to be in a _test.go file

@mgabeler-lee-6rs

Copy link
Copy Markdown

I believe this will also fix #161 which is a dupe of #142

@amanbolat

Copy link
Copy Markdown

Hi there,
Is there anything missing in this PR that requires contribution, or it can be merged?

@landonalder

Copy link
Copy Markdown

This is also a problem for us that I just discovered today. If this could be merged, that would be amazing @mckern

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: raw literal with backslashes becomes "unescaped"

5 participants