Leverage workspace features and rename crates#33
Conversation
Libraries should avoid locking in logging solutions. Future work could instead instrument the function behind a feature flag.
Also removes `tracing` library lock-in.
Begin moving away from crate-wide error.
gibbz00
force-pushed
the
off_the_rails_v2
branch
from
1739780 to
e8099b1
Compare
gibbz00
changed the title
gibbz00
force-pushed
the
off_the_rails_v2
branch
from
e72f910 to
46a5075
Compare
|
Since the "a" in every crate stands for "Asterisk" I don't like prefixing the names with "asterisk-rs". A suggestion is to rename the directories to "rest-interface", "gateway-interface" and "management-interface" (possibly dropping the "interface" part in the directory names) and naming the crates themselves "asterisk-rs-rest-interface" and so on. That makes the names unique, pop up on crates.io when searching for Asterisk and doesn't implicitly contain the word "Asterisk" twice. |
|
I don't think making the dependencies at workspace level makes sense for all of them. E.g. AMI and AGI aren't HTTP-based but TCP-based IIRC so e.g. tokio-util is needed for them while request is only for ARI. Before the development of AMI and AGI starts, I think it's best to keep the dependencies local to ARI and move the relevant ones to the workspace level as the other parts get implemented. |
2 participants
Depends on #32