EPD-2106: enable slack and github notifications for V2 - #374
Merged
josorio-autoblocks merged 3 commits intoJul 29, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Greptile Summary
This PR implements Slack and GitHub notification support for the V2 testing framework in the Autoblocks Python SDK. The main changes include:
Core V2 Notification Functions: Two new functions are added to
autoblocks/_impl/testing/v2/api.py:send_v2_slack_notification(): Sends Slack notifications using app-scoped endpoints (/apps/{app_slug}/...)send_v2_github_comment(): Posts GitHub comments with semaphore-based concurrency controlBoth functions follow the same patterns as their V1 counterparts but use V2's app-scoped API architecture instead of direct endpoints.
Integration with Test Execution: The notification system is integrated into the V2 test runner (
autoblocks/_impl/testing/v2/run.py) where notifications are dispatched after test completion using anall_settledpattern. This ensures notification failures don't impact test results while still attempting to deliver both Slack and GitHub notifications.Conditional Logic: GitHub comments are only sent when a
build_idis present (typically in CI environments), while Slack notifications are always attempted if properly configured. This matches the existing V1 behavior and integrates well with CI/CD workflows.The implementation reuses utility functions and error handling patterns from the V1 codebase, maintaining consistency across the SDK while adapting to V2's architectural differences. The changes also include minor developer environment cleanup in
.gitignorefor Cursor IDE and Taskmaster tool configurations.PR Description Notes:
.gitignorecomment: "Curor" should be "Cursor"Confidence score: 4/5
.gitignorefile needs attention for the typo, and the empty PR description should be addressed for better documentation