update: Refactor parameter naming from maxTokens to maxCompletionToke… - #370
Merged
Conversation
…ns across tests and models for consistency with API changes.
josorio-autoblocks
approved these changes
Jul 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Greptile Summary
This PR implements a consistent renaming of token limit parameters across the Python SDK's test files, changing from the generic
maxTokensto the more specificmaxCompletionTokens. The change affects multiple test files and parameter classes includingQuestionAnswererParams,TextSummarizationParams, andUsedByCiDontDeleteParams.This change improves API clarity by explicitly indicating that the token limit applies specifically to completion tokens (response generation) rather than total tokens or prompt tokens. This distinction is particularly important for LLM APIs where prompt and completion tokens are tracked and billed separately.
The changes are consistent across the codebase, affecting:
Confidence score: 5/5
6 files reviewed, 1 comment
Edit PR Review Bot Settings | Greptile