Skip to content

update: Refactor parameter naming from maxTokens to maxCompletionToke… - #370

Merged
josorio-autoblocks merged 15 commits into
mainfrom
lukabura/epd-2110-update-python-sdk
Jul 28, 2025
Merged

update: Refactor parameter naming from maxTokens to maxCompletionToke…#370
josorio-autoblocks merged 15 commits into
mainfrom
lukabura/epd-2110-update-python-sdk

Conversation

@lukabura-ab

@lukabura-ab lukabura-ab commented Jul 18, 2025

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR implements a consistent renaming of token limit parameters across the Python SDK's test files, changing from the generic maxTokens to the more specific maxCompletionTokens. The change affects multiple test files and parameter classes including QuestionAnswererParams, TextSummarizationParams, and UsedByCiDontDeleteParams.

This change improves API clarity by explicitly indicating that the token limit applies specifically to completion tokens (response generation) rather than total tokens or prompt tokens. This distinction is particularly important for LLM APIs where prompt and completion tokens are tracked and billed separately.

The changes are consistent across the codebase, affecting:

  • Parameter class definitions
  • Test assertions
  • Mock API responses
  • V2 prompt implementations

Confidence score: 5/5

  1. This PR is very safe to merge as it's a well-structured rename with consistent changes across all relevant files
  2. The changes are thorough, well-tested, and improve API clarity without introducing new behavioral changes
  3. While all files look good, developers should pay extra attention to:
    • tests/e2e/prompts.py (core parameter definitions)
    • tests/e2e/prompts_v2/apps/ci_app/prompts.py (V2 implementation)

6 files reviewed, 1 comment
Edit PR Review Bot Settings | Greptile

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewing changes made in this pull request

Comment thread tests/e2e/prompts_v2/apps/ci_app/prompts.py Outdated
@josorio-autoblocks
josorio-autoblocks merged commit e6a4e2b into main Jul 28, 2025
6 checks passed
@josorio-autoblocks
josorio-autoblocks deleted the lukabura/epd-2110-update-python-sdk branch July 28, 2025 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants