Conversation
|
Warning Review limit reached
More reviews will be available in 58 minutes and 6 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more credits in the billing tab to continue. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR refactors and trims legacy code paths related to enemy name matching and UI rendering, aiming to simplify logic and reduce unnecessary work during tracking and display.
Changes:
- Removes legacy/fallback enemy name matching logic and relies on
match_type-driven matching. - Simplifies
tracker_uiGDI-font rendering by removing the extraprogress_textGDI object and related font settings. - Cleans up unused legacy functions and duplicate data definitions (parser legacy line parser, unused player-id helper, duplicate Bat/Bats family entry).
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| lib/tracker_ui.lua | Removes legacy GDI progress text objects/font settings; keeps progress rendering via ImGui progress bar. |
| lib/parser.lua | Removes unused legacy parse_enemy_line function. |
| lib/packet_handler.lua | Removes unused get_player_id() and related unused local variable. |
| lib/family.lua | Removes duplicate family key entry (introduces a potential regression for plural family names). |
| AMANTracker.lua | Removes legacy enemy matching fallback; minor cleanup of parsing start and regime confirmation output. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ["Bat"] = { | ||
| includes = { "Bat", "Bats", "Stirge", "Gaylas" }, | ||
| excludes = { "Gigas's", "Goblin's" } | ||
| }, |
| -- Try ies -> y transformation (e.g., defeated "Damselfly", list has "Damselflies") | ||
| if enemy_name:sub(-1) == "y" and enemy.name == enemy_name:sub(1, -2) .. "ies" then | ||
| return enemy, i; | ||
| end | ||
| else | ||
| -- Legacy support: no match_type specified, try all methods | ||
|
|
||
| -- Exact match | ||
| if enemy.name == enemy_name then | ||
| return enemy, i; | ||
| end | ||
|
|
||
| -- Check if enemy.name is a family pattern | ||
| local family_type = family.extract_family_type(enemy.name); | ||
| if family_type then | ||
| if family.is_family_member(enemy_name, family_type) then | ||
| return enemy, i; | ||
| end | ||
| end | ||
|
|
||
| -- Try singular/plural variations | ||
| if enemy.name == enemy_name .. "s" then | ||
| return enemy, i; | ||
| end | ||
| if enemy.name == enemy_name .. "es" then | ||
| return enemy, i; | ||
| end | ||
| if enemy.name:sub(-1) == "s" and enemy.name:sub(1, -2) == enemy_name then | ||
| return enemy, i; | ||
| end | ||
| if enemy.name:sub(-2) == "es" and enemy.name:sub(1, -3) == enemy_name then | ||
| return enemy, i; | ||
| end | ||
|
|
||
| -- Try y -> ies transformation | ||
| if enemy.name:sub(-3) == "ies" and enemy.name:sub(1, -4) .. "y" == enemy_name then | ||
| return enemy, i; | ||
| end | ||
| if enemy_name:sub(-1) == "y" and enemy.name == enemy_name:sub(1, -2) .. "ies" then | ||
| return enemy, i; | ||
| end | ||
| end |
No description provided.