Add a multi-threaded compositor#5997
Open
Geenz wants to merge 10 commits into
Open
Conversation
More or less mirrors swap chains from other APIs - and acts as an abstraction for future work. Also gets us away from directly writing to FBO 0, which was complicating some other compositor work.
Ported from a previous LLCompositor branch - idea is to introduce thread safety between multiple OpenGL contexts. Currently only used on LLRenderTarget and LLImageGL.
Multi-context compositor, test layers & sync Add multi-context composition, threading, and test layers. Also add some synchronization here - this still needs a better vsync signal, but that's likely to come as part of a new frame limiter setup.
- Supports VSync much better on macOS - Use thread safe ref counting where we need it - Make the swapchain less swapchain (more or less scaffolding right now) and have zero-copy writing to the back buffer. - Simplify LLRenderTarget to be closer to its pre-compositor state - With the notable exception of we use LLImageGLs now instead of raw texture names - Make leases opt-in rather than "everyone gets a lease"
…r target when it's not quite ready.
github-actions
Bot
added
c/cpp
cmake
llwindow
llappearance
llcommon
llprimitive
llrender
objc
labels
Collaborator
Author
|
A few things to note:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for a multi-threaded compositor in the viewer to do things like separating the UI into its own thread, and eventually moving the renderer onto its own thread.