Skip to content

#5994 More llprocess tests#5996

Merged
akleshchev merged 3 commits into
developfrom
andreyk/llprocess_extra_tests
Jul 14, 2026
Merged

#5994 More llprocess tests#5996
akleshchev merged 3 commits into
developfrom
andreyk/llprocess_extra_tests

Conversation

@akleshchev

@akleshchev akleshchev commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

8 more llprocess tests to ensure smooth apr to boost transition.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR expands llprocess unit test coverage by adding several new test cases focused on pipe handling, process lifecycle/status, ReadPipe boundary behaviors, and failure reporting—supporting confidence during the APR → Boost transition.

Changes:

  • Added new tests covering simultaneous stdin/stdout/stderr piping, process state transitions, and rapid process creation/teardown.
  • Added tests for ReadPipe event size limits and boundary behaviors (find(), contains(), peek()).
  • Added a test for invalid executable launch failure reporting via postend.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread indra/llcommon/tests/llprocess_test.cpp Outdated
Comment thread indra/llcommon/tests/llprocess_test.cpp Outdated
Comment thread indra/llcommon/tests/llprocess_test.cpp Outdated
Comment thread indra/llcommon/tests/llprocess_test.cpp Outdated
@akleshchev akleshchev force-pushed the andreyk/llprocess_extra_tests branch from b657ed3 to bfd3501 Compare July 13, 2026 21:45

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

Comment thread indra/llcommon/tests/llprocess_test.cpp Outdated
Comment thread indra/llcommon/tests/llprocess_test.cpp
akleshchev and others added 2 commits July 14, 2026 02:01
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@akleshchev akleshchev merged commit d9f6702 into develop Jul 14, 2026
15 checks passed
@akleshchev akleshchev deleted the andreyk/llprocess_extra_tests branch July 14, 2026 05:17
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 14, 2026
@akleshchev akleshchev linked an issue Jul 14, 2026 that may be closed by this pull request
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace apr in llprocess with boost::process

3 participants