Skip to content

Replace apr with boost in LLProcess #5988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
akleshchev wants to merge 29 commits into
base: develop
Choose a base branch
from
+913 −1,403
Draft

Replace apr with boost in LLProcess #5988

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
0554571
Replace apr process with boost process
akleshchev Jul 10, 2026
626b1f5
Fix macOS CI failures: SIGPIPE and EINTR in LLProcess
Copilot Jul 11, 2026
67956f8
Fix destructor: use waitpid(WNOHANG) instead of mChild->running()
Copilot Jul 11, 2026
0e32b17
Fix 8 failing INTEGRATION_TEST_llprocess test cases
Copilot Jul 11, 2026
9093b52
Speed up macOS viewer app tarball creation in CI
Copilot Jul 11, 2026
8f5bfd3
Drain all ready LLProcess pipe events on exit
Copilot Jul 11, 2026
d288de5
Fix WritePipeImpl to use self-chaining startAsyncWrite
Copilot Jul 11, 2026
2f0dfa6
Pump LLProcess writes before poll loop
Copilot Jul 11, 2026
dbcbe5e
Fix LLProcess tick ordering to prevent LLLeap timeout
Copilot Jul 11, 2026
f4d2a7f
Clarify LLProcess tick ordering rationale
Copilot Jul 11, 2026
71e45ae
Tighten LLProcess tick comment wording
Copilot Jul 11, 2026
b4bad96
Fix ReadPipeImpl mLimit backpressure causing INTEGRATION_TEST_llleap …
Copilot Jul 12, 2026
0f1e967
Address code review: remove misleading inventName comment, fix double…
Copilot Jul 12, 2026
623cc34
Fix stale wstdin() comment reference and malformed C comment closer
Copilot Jul 12, 2026
8f5b579
Add virtual WritePipe::tick(), promote pipe ownership to shared_ptr
Copilot Jul 12, 2026
d4a491c
Improve comments: name deadlock explicitly, clarify std::shared_ptr
Copilot Jul 12, 2026
52b103a
Cleanup obsolete llprocess code
akleshchev Jul 12, 2026
a6eaa7e
Restore original eof event contract in ReadPipe
Copilot Jul 12, 2026
3c77807
Restore all 7 original ReadPipe event fields
Copilot Jul 12, 2026
3255819
Restore whichfile
akleshchev Jul 12, 2026
089aee5
Fix Windows kill() exit code and stdout/stderr EOF
Copilot Jul 12, 2026
3b78e9c
Fix Windows EOF event race after process exit
Copilot Jul 12, 2026
756e24a
Fix 4 Windows CI test failures in llprocess
Copilot Jul 13, 2026
ea0c5f3
Cleanup old apr headers and helpers
akleshchev Jul 13, 2026
3412791
Fix param validation
akleshchev Jul 13, 2026
4564900
Fix LLProcess::kill() to return true for null process ptr
Copilot Jul 13, 2026
391a83d
Safeguard handleExit
akleshchev Jul 13, 2026
5de5c8b
Add mIOContext.restart() before poll loop in LLProcess::tick()
Copilot Jul 13, 2026
ad3bcf4
Address review feedback
akleshchev Jul 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion indra/cmake/Boost.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,14 @@ if (WINDOWS)
libboost_url-mt${addrsfx}
PATHS "${ARCH_PREBUILT_DIRS_RELEASE}" REQUIRED NO_DEFAULT_PATH)

# Add Boost.Process library
find_library(BOOST_PROCESS_LIBRARY
NAMES
libboost_process
libboost_process-mt
libboost_process-mt${addrsfx}
PATHS "${ARCH_PREBUILT_DIRS_RELEASE}" REQUIRED NO_DEFAULT_PATH)
Comment thread
akleshchev marked this conversation as resolved.
Comment thread
akleshchev marked this conversation as resolved.

else (WINDOWS)

find_library(BOOST_CONTEXT_LIBRARY
Expand Down Expand Up @@ -104,6 +112,14 @@ else (WINDOWS)
boost_url-mt${addrsfx}
PATHS "${ARCH_PREBUILT_DIRS_RELEASE}" REQUIRED NO_DEFAULT_PATH)

# Add Boost.Process library
find_library(BOOST_PROCESS_LIBRARY
NAMES
boost_process
boost_process-mt
boost_process-mt${addrsfx}
PATHS "${ARCH_PREBUILT_DIRS_RELEASE}" REQUIRED NO_DEFAULT_PATH)
Comment thread
akleshchev marked this conversation as resolved.
Comment thread
akleshchev marked this conversation as resolved.

endif (WINDOWS)

target_link_libraries(ll::boost INTERFACE
Expand All @@ -112,7 +128,8 @@ target_link_libraries(ll::boost INTERFACE
${BOOST_FILESYSTEM_LIBRARY}
${BOOST_PROGRAMOPTIONS_LIBRARY}
${BOOST_THREAD_LIBRARY}
${BOOST_URL_LIBRARY})
${BOOST_URL_LIBRARY}
${BOOST_PROCESS_LIBRARY})
Comment thread
akleshchev marked this conversation as resolved.

if (LINUX)
target_link_libraries(ll::boost INTERFACE rt)
Expand Down
Loading
Loading