Allow rulesets on legacy functions#177
Merged
Merged
Conversation
tapple
approved these changes
Jul 10, 2026
tapple
left a comment
tapple
left a comment
Contributor
There was a problem hiding this comment.
The generated files look right. I can't really check anything else. Approved
| bool_semantics: bool | ||
| """Represents a boolean""" | ||
| ruleset: str | None | ||
| """Name of a builder-ruleset for dict-to-list coercion""" |
Contributor
There was a problem hiding this comment.
nice. I'll need to add this to the type-semantics dict in #164
| args: | ||
| - type: string | ||
| - type: table | ||
| - type: any |
Contributor
There was a problem hiding this comment.
in the selene_type function:
lsl-definitions/lsl_definitions/generators/slua.py
Lines 132 to 136 in 8fd2420
add a rule
if type_str.startswith("list | "):
return "table"so this stays a table.
Maybe I should move some of that selene logic to LSLTypeSemantics in #164
HaroldCindy
approved these changes
Jul 13, 2026
HaroldCindy
left a comment
HaroldCindy
left a comment
Collaborator
There was a problem hiding this comment.
Maybe verb-ify llprim.particleSystem() -> llprim.setParticleSystem()? Other than that lgtm.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows the ruleset tables to be use in the legacy functions, and removes llhttp:request
Issue #175
related PRs
secondlife/slua#87
https://github.com/secondlife/server/pull/2574