Add missing constant SIT_OK#114
Merged
Merged
Conversation
Contributor
|
If successful returns 1 you mean? |
Contributor
Author
|
yes. I defined SIT_OK = 1 |
tapple
commented
Apr 27, 2026
| constexpr int32_t LSL_GEN_SIT_NO_ACCESS = -6; | ||
| constexpr int32_t LSL_GEN_SIT_NO_EXPERIENCE_PERMISSION = -2; | ||
| constexpr int32_t LSL_GEN_SIT_NO_SIT_TARGET = -3; | ||
| constexpr int32_t LSL_GEN_SIT_OK = 1; |
Contributor
Author
There was a problem hiding this comment.
The wiki is correct: this script seats me and prints 1:
default { state_entry() {
llSitTarget(<0, 0, 1>, ZERO_ROTATION);
llOwnerSay((string)llSitOnLink(llGetOwner(), LINK_THIS));
}}[12:13 PM] Object: 1
HaroldCindy
reviewed
May 6, 2026
| type: integer | ||
| value: -3 | ||
| SIT_OK: | ||
| member-of: [SitError] |
Collaborator
There was a problem hiding this comment.
🔕 May have to do another pass at these names later, "error" no longer fits. Doesn't block this at all.
HaroldCindy
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to the wiki,
llSitOnLinkhas 8 possible return values. But, only 7 of them are named constants. Add the missing one.Discovered while auditing the
Errorenums for #113