Fix turbine velocity sampling to avoid abrupt changes in sampled velo… - #51
Open
okcfdlab wants to merge 43 commits into
Open
Fix turbine velocity sampling to avoid abrupt changes in sampled velo…#51okcfdlab wants to merge 43 commits into
okcfdlab wants to merge 43 commits into
Conversation
…CGStab is stagnating)
…(use T predictor when using Cn for T)
…ade explicit filter selectable per-direction
…to subtract mean after updating boundary conditions
…trix multiplication does not ensure that Ucat is updated to the last iterate
…zation for both overset and non-overset
…needs further testing
… for the RHS, cleaned code
…ed mean pressure gradient and bulk velocity controller selectable in control.dat
…nd UpdateImmersedBCs - this is crucial for IMEX schemes where the cartesian velocity might not be up-to-date with the last iterate
…ft Rayleight damping layer
…ft Rayleight damping layer
… last step adaptation logic
…ft Rayleight damping layer
…stance so with overset all domains would have them. Switched to specify start and end coords
…city when time step changes
sebastipa
reviewed
Jun 9, 2026
sebastipa
left a comment
sebastipa
left a comment
Owner
There was a problem hiding this comment.
I have fixed this issue in the master branch already. So now all actuator models do not use upstream sampling anymore, following the change that we made in the ALM some time ago with Jonas. This branch can be removed and the pull request cancelled if you want.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…city when time step changes, for example, for file I/O. The suggested fix takes the max of the current and old timestep size for sampling upstream along the local streamline. This is implemented for ADM, uniform ADM, and AFM.