Add initial SEAPATH SLES standalone support#945
Open
emontmas wants to merge 12 commits into
Open
Conversation
Signed-off-by: Elinor Montmasson <elinor.montmasson@savoirfairelinux.com>
The file may not be created by all base distro, therefore create it before modifying it. Signed-off-by: Elinor Montmasson <elinor.montmasson@savoirfairelinux.com>
Commit [1] added an initial modification to GRUB_CMDLINE_LINUX to add
a space at the beginning. Otherwise, the following task could add
a parameter that is already present in GRUB_CMDLINE_LINUX at the very
beginning.
Example: GRUB_CMDLINE_LINUX="foo=bar" would match
^(GRUB_CMDLINE_LINUX=(?!.* foo=bar)\"[^\"]*)(\".*)
because the space before "foo" doesn't exist in the file.
However, this can be simply solved by fixing the negative lookahead to
take into account this possibility.
Fix the regex and remove the task adding the initial space.
Note that this task was preventing the role from being idempotent
because the "Make grub conf" task would create a second initial space.
[1]: seapath@c93bf0f
Signed-off-by: Elinor Montmasson <elinor.montmasson@savoirfairelinux.com>
Signed-off-by: Elinor Montmasson <elinor.montmasson@savoirfairelinux.com>
Signed-off-by: Elinor Montmasson <elinor.montmasson@savoirfairelinux.com>
Some distributions choose to provide /usr/lib/systemd/system.conf instead of /etc/systemd/system.conf. In that case, /etc/systemd/system.conf shouldn't be created, because systemd ignores /etc/systemd/system.conf if it founds /usr/lib/systemd/system.conf [1]. Instead, set the hardware watchdog related configurations in a drop-in file, which will be compatible regardless of the distribution's choice for the system-wide configuration file. [1]: https://www.freedesktop.org/software/systemd/man/latest/systemd-system.conf.html#Configuration%20Directories%20and%20Precedence Signed-off-by: Elinor Montmasson <elinor.montmasson@savoirfairelinux.com>
Add seapath_setup_prerequissles.yaml playbook with distro configuration for SEAPATH SLES machines. This playbook follows an approach similar to what is done with SEAPATH Debian configuration. Signed-off-by: Elinor Montmasson <elinor.montmasson@savoirfairelinux.com>
Some distributions choose to provide /usr/lib/systemd/resolved.conf instead of /etc/systemd/resolved.conf. In that case, /etc/systemd/resolved.conf will be ignored by systemd because /usr/lib/systemd/resolved.conf has a higher priority [1]. Instead, configure the SEAPATH specific resolved configurations as a drop-in file. This will be compatible regardless of the distribution's choice for the system-wide configuration file. [1]: https://www.freedesktop.org/software/systemd/man/latest/resolved.conf.html#Configuration%20Directories%20and%20Precedence Signed-off-by: Elinor Montmasson <elinor.montmasson@savoirfairelinux.com>
Signed-off-by: Elinor Montmasson <elinor.montmasson@savoirfairelinux.com>
Signed-off-by: Elinor Montmasson <elinor.montmasson@savoirfairelinux.com>
Signed-off-by: Elinor Montmasson <elinor.montmasson@savoirfairelinux.com>
Signed-off-by: Elinor Montmasson <elinor.montmasson@savoirfairelinux.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR bring the initial support for the SEAPATH SLES flavor:
SLESseapath distro type to thedetect_seapath_distrorole.With this PR, the
playbook/seapath_setup_main.yamland associated roles now supports configuring a SEAPATH SLES standalone hypervisor.Note that following PRs will bring compatibility for SEAPATH SLES cluster machine configuration, hardening confgiruation and cukinia tests.