Virtual cluster CI trigger#943
Conversation
Add the virtual cluster CI to the list of CIs triggered when a PR is created on the Ansible repository. Signed-off-by: Paul Le Guen de Kerneizon <paul.leguendekerneizon@savoirfairelinux.com>
This allows to call this workflow from other workflow. Signed-off-by: Paul Le Guen de Kerneizon <paul.leguendekerneizon@savoirfairelinux.com>
Paullgk
force-pushed
the
main
branch
3 times, most recently
from
8cb0b69 to
1ad2191
Compare
| uses: seapath/virtual-cluster/.github/workflows/ansible-setup.yml@main | ||
| with: | ||
| ansible_repo: https://github.com/seapath/ansible.git | ||
| ansible_repo: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.repo.clone_url || 'https://github.com/seapath/ansible.git' }} |
There was a problem hiding this comment.
Do we really want to launch the virtual cluster with different ansible repository ?
For me, the only use case is to launch it from seapath ansible repo, with a PR eventually coming from a fork
This is already covered by a classic actions/checkout
There was a problem hiding this comment.
In this case, how can we test the modification provided by the PR?
There was a problem hiding this comment.
It is precisely the job of action/checkout to download the code from the PR when a workflow is triggered on pull_request
ci.yml set up some hidden configuration variables like GITHUB_REF and other kind. It is then used by the other workflow.
It is already done like that for ci-qa and ci-molecule if you want to have a look
There was a problem hiding this comment.
Maybe we can do the opposite.
The action lives in this repo and this repo clone virtual-cluster.
| uses: ./.github/workflows/ci-centos.yml | ||
|
|
||
| ci-virtual-cluster: | ||
| needs: ci-molecule |
There was a problem hiding this comment.
Do we really need ci-molecule?
| uses: seapath/virtual-cluster/.github/workflows/ansible-setup.yml@main | ||
| with: | ||
| ansible_repo: https://github.com/seapath/ansible.git | ||
| ansible_repo: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.repo.clone_url || 'https://github.com/seapath/ansible.git' }} |
There was a problem hiding this comment.
Maybe we can do the opposite.
The action lives in this repo and this repo clone virtual-cluster.
| uses: seapath/virtual-cluster/.github/workflows/ansible-setup.yml@main | ||
| with: | ||
| ansible_repo: https://github.com/seapath/ansible.git | ||
| ansible_repo: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.repo.clone_url || 'https://github.com/seapath/ansible.git' }} |
There was a problem hiding this comment.
We want one job per flavors.
| uses: seapath/virtual-cluster/.github/workflows/ansible-setup.yml@main | ||
| with: | ||
| ansible_repo: https://github.com/seapath/ansible.git | ||
| ansible_repo: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.repo.clone_url || 'https://github.com/seapath/ansible.git' }} |
There was a problem hiding this comment.
We also need to do all the CI stuff except latencies tests.
The workflow should be something like that.
- install prerequisist
- checkout ansible
- checkout virtual-cluser
- download image
- configure tvars
- in virtual-cluser
make init apply start ansible-ping - next run regular CI files
Paullgk
force-pushed
the
main
branch
4 times, most recently
from
4bd1d08 to
fc32f9a
Compare
Currently, the workflow test the PR changes based on the SEAPATH Ansible repository. Add the needed modifications to test the changes from the Ansible repository where the PR is coming from. Signed-off-by: Paul Le Guen de Kerneizon <paul.leguendekerneizon@savoirfairelinux.com>
Paullgk
force-pushed
the
main
branch
2 times, most recently
from
d4c3918 to
7347062
Compare
3 participants
Hello,
This PR adds the trigger of the virtual-cluster CI, which allows to test the PR in a SEAPATH Yocto virtual cluster.