Deliver: Review Conventions - #58
Merged
Merged
Conversation
Author: architect Waves: 2 Tasks: 3 Out-of-scope deps: no
Plan: .agents/plans/review-conventions.md (Status + approved event written by: node harness/cli.js approve)
Wave 1, Task 1.1 Validated: AC#2, AC#3, AC#4 — bash scripts/test-lint-shell-safety.sh exits 0 (ALL PASS, 8 cases); bash scripts/lint-shell-safety.sh exits 0 on the real tree with baseline warnings only (6 frozen offenders)
Wave 1, Task 1.2 Validated: AC#1 — Coding Conventions section contains exactly the four bullets; git diff CLAUDE.md confined to that section; scripts/lint-agent-files.sh exits 0
Wave 1 log bookkeeping (a commit cannot embed its own hash)
Wave 2, Task 2.1 Validated: AC#5, AC#6 — yaml parses; local lint exit 0; additive diff Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the /rad-insights Findings Recurrence suggestions (2026-07-03 session): the four recurring-category convention bullets land in CLAUDE.md, and the security suggestion becomes a real lint with a baseline ratchet.
What landed (2 waves, 3 tasks, all 6 ACs)
scripts/lint-shell-safety.sh— flags shell scripts interpolating positional/env-derived variables intogit/jq/node -e/evalwithout a STRONG guard (regex[[ =~ ]]orcasevalidation;-z/-falone doesn't qualify). Grep-based heuristic, precision-first, limits documented in the header.lint-shell-safety-baseline.txt): pre-existing offenders warn (⚠ baseline:) instead of failing; new code must meet the strict bar; fixed entries self-report as⚠ stale baseline:. The actual offender run diverged from the plan's estimate — baselined: check-events-append-only.sh, check-plan-approved.sh, check-scope.sh, classify-low-risk.sh, rad-status.sh, worktree-lifecycle.sh (check-approval-integrity.sh and open-pr.sh came up clean). Remediation of the six is a named follow-up plan.test-lint-shell-safety.sh): guarded pass / unguarded fail / baselined warn-pass / stale-baseline warn / usage exit-2, plus env-into-node-e and case-guard cases. Auto-run by the existing script-tests CI job.shell-safety-lintjob (checkout + invoke, mirrors agent-file-lint).Verification
.agents/logs/review-conventions-2026-07-03.md🤖 Generated with Claude Code