Improve formatting; include function signatures at runtime for printing#232
Merged
Conversation
…dard library; automatic generation from typedefs and validation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Um this is a big pr.
Does more than just fix snowflakes.
Uses mluau's
create_function_with_debugto include function signatures at runtime for every function in the seal standard library. You can now print thefslibrary for type signatures for every fs library function. And all the other libraries. It's amazing.The signature_generation codebase in src/scripts creates a bunch of cstr constants from our typedefs that we use in a new helper method to TableBuilder, with_function_and_signature. This means we now should be creating typedefs before writing implementations in Rust. Run
signature_generation/validate.luauto make sure everything exposed in Rust has a signature in Luau. That currently fails because there's a few undocumented functions that should be removed, eventually.Closes #231