Update the benchmark to load datasets from multiple S3 buckets when None is specified#607
Open
R-Palazzo wants to merge 5 commits into
Open
Update the benchmark to load datasets from multiple S3 buckets when None is specified#607R-Palazzo wants to merge 5 commits into
R-Palazzo wants to merge 5 commits into
Conversation
Contributor
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #607 +/- ##
==========================================
+ Coverage 85.67% 85.80% +0.13%
==========================================
Files 40 40
Lines 3679 3742 +63
==========================================
+ Hits 3152 3211 +59
- Misses 527 531 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve #604
CU-86b9zwpcu
This PR includes:
download_demo()to getsdv_dataset. This works for public datasets or for users with SDV-Enterprise installed. Otherwise, because on SDV there is some validation to allow access to the public bucket only, I reused the SDV logic here, so it works if the S3 client is created with valid credentials (from input keys or env variables).download_demo(), we no longer save the dataset locally._generate_job_arg_list: Now we're downloading datasets only once instead of once per job before.