Skip to content

Stop changelog-notes extractor at <!-- scriv-end-here --> marker#11

Merged
sderev merged 1 commit into
mainfrom
changelog-notes-fix
Apr 14, 2026
Merged

Stop changelog-notes extractor at <!-- scriv-end-here --> marker#11
sderev merged 1 commit into
mainfrom
changelog-notes-fix

Conversation

@sderev

@sderev sderev commented Apr 9, 2026

Copy link
Copy Markdown
Owner

What changed

  • .ci/changelog-notes boundary regex now also stops at <!-- scriv-end-here -->.

Why

  • The extractor stopped at ## headers and <a id= anchors but not at the trailing scriv marker. Once scriv emits <!-- scriv-end-here -->, the extractor would silently include it in release notes.
  • Port of the same fix already applied in shellgenius.

How to test

  • Run .ci/changelog-notes 0.3.0 — output should be unchanged (no <!-- scriv-end-here --> in current CHANGELOG).
  • Create a test changelog with <!-- scriv-end-here --> after a version section and verify the extractor stops before it:
    echo -e "## 0.0.1\n\nFixed\n-----\n* Bug fix\n\n<!-- scriv-end-here -->\n\n## 0.0.0\n" > /tmp/test-cl.md
    .ci/changelog-notes 0.0.1 /tmp/test-cl.md
    # Should print only "### Fixed\n* Bug fix", without the scriv marker
    
    

Risk/comp notes

  • Low risk — adds a stop condition; existing behavior unchanged for CHANGELOGs without the marker.

Changelog fragment: no (internal CI tool, no user-visible behavior change)

The boundary regex in `.ci/changelog-notes` stopped at `## `
headers and `<a id=` anchors, but not at the trailing scriv
marker.  Once scriv emits `<!-- scriv-end-here -->`, the extractor
would silently include it in release notes.

Port the fix from shellgenius so the extractor also stops at
`<!-- scriv-end-here -->`.

Co-authored-by: AI <ai@sderev.com>
@sderev sderev merged commit 8225e62 into main Apr 14, 2026
6 checks passed
@sderev sderev deleted the changelog-notes-fix branch April 14, 2026 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant