ci: golangci-lint workflow and lint fixes#450
Open
steiler wants to merge 2 commits into
Open
Conversation
Add Go Checks workflow and golangci-lint v2 config (exclude ygot-generated schema). Resolve errcheck, staticcheck, govet, ineffassign, and unused issues across CLI, datastore, server, pool, tree, and utils. Co-authored-by: Cursor <cursoragent@cursor.com>
Open
Remove `_ = logf.IntoContext(ctx, log)` lines flagged by @alexandernorth in noop.go and server/datastore.go. In noop.Get the logger was also unused, so remove that too. In server.CreateDataStore the log is still used, so only the dead assignment is dropped. Co-authored-by: Cursor <cursoragent@cursor.com>
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #323
Summary
main(checkout/setup-go v5, golangci-lint-action v8, linter v2.4)..golangci.yml(config version 2) and exclude ygot-generatedtests/sdcioygot/sdcio_schema.gofrom reported issues.inline/reflect.Pointer, ineffassign, unused, import cleanup, small correctness fixes such aserrors.Joinaccumulation in validation results).Test plan
go test ./... -shortgolangci-lint run ./...