Skip to content

(fix): zarr bound#1976

Merged
ilan-gold merged 1 commit into
mainfrom
ig/bound_zarr
Apr 24, 2025
Merged

(fix): zarr bound#1976
ilan-gold merged 1 commit into
mainfrom
ig/bound_zarr

Conversation

@ilan-gold

Copy link
Copy Markdown
Contributor

See zarr-developers/zarr-python#2998

  • Closes #
  • Tests added
  • Release note added (or unnecessary)

@ilan-gold ilan-gold added this to the 0.12.0 milestone Apr 24, 2025
@codecov

codecov Bot commented Apr 24, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.06%. Comparing base (6d468a2) to head (60d535a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1976      +/-   ##
==========================================
+ Coverage   83.35%   85.06%   +1.70%     
==========================================
  Files          47       47              
  Lines        6848     6848              
==========================================
+ Hits         5708     5825     +117     
+ Misses       1140     1023     -117     

see 16 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@flying-sheep

Copy link
Copy Markdown
Member

should this be an upper bound?

@ilan-gold

ilan-gold commented Apr 24, 2025

Copy link
Copy Markdown
Contributor Author

should this be an upper bound?

Should it be exclusion? I thought upper bound would be safer for now but exclusion would work

@flying-sheep

Copy link
Copy Markdown
Member

I personally prefer exclusion when I know that the next release has the fix.

When we don’t know when the fix will come, we need to do an upper bound like you did. But then it’s a temporary fix and we need to be on top of it and make it more precise ASAP.

@ilan-gold

ilan-gold commented Apr 24, 2025

Copy link
Copy Markdown
Contributor Author

I opened zarr-developers/zarr-python#3015 but I don't know when it will be merged and Josh Moore said the next release might be very quick: zarr-developers/zarr-python#3007 (comment)

I will be on top of it because I opened the PR :)

@ilan-gold
ilan-gold merged commit 45acdb2 into main Apr 24, 2025
@ilan-gold
ilan-gold deleted the ig/bound_zarr branch April 24, 2025 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants