after deployment of the salad contracts, we now wait for one epoch to pass.#79
Open
reuvenpo wants to merge 15 commits into
Open
after deployment of the salad contracts, we now wait for one epoch to pass.#79reuvenpo wants to merge 15 commits into
reuvenpo wants to merge 15 commits into
Conversation
… pass. This is a workaround to a current issue where if the deployment and the first task happen in the same epoch, we hit several race conditions in the protocol implementation
Cashmaney
reviewed
Jan 23, 2020
reuvenpo
commented
Jan 23, 2020
Cashmaney
approved these changes
Jan 26, 2020
…ives when an epoch transition event happens
…ther than 20 times
…t-one-epoch-after-delpoy
mdemri
reviewed
Jan 30, 2020
| addresses = sys.argv[1:] | ||
| for address in addresses: | ||
| print(f'distributing ether to {address}') | ||
| request_coins('http://contract.reuven.services.enigma.co:8001', address, 'ether') |
Contributor
There was a problem hiding this comment.
replace reuven with os.environ['enigma_namespace']
Contributor
Author
There was a problem hiding this comment.
I ended up implementing this by passing it in as an environment variable, which is replaced dynamically in the kubernetes environment.
Implemented in:
https://github.com/enigmampc/kubernetes/pull/26
5755845
scrtlabs/salad#53 (commit f4e726f)
Contributor
Author
reuvenpo
force-pushed
the
salad-operator-wait-one-epoch-after-delpoy
branch
from
5755845 to
4f28dd5
Compare
Cashmaney
requested changes
Feb 2, 2020
Cashmaney
approved these changes
Feb 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a workaround to a current issue where if the deployment and the first task happen in the same epoch, we hit several race conditions in the protocol implementation.
While working on this I also added the following functionality: