Skip to content

Expose jagged assist claim helper#64

Merged
hero78119 merged 7 commits into
mainfrom
fuse_jagged_assist_claim
Jun 22, 2026
Merged

Expose jagged assist claim helper#64
hero78119 merged 7 commits into
mainfrom
fuse_jagged_assist_claim

Conversation

@hero78119

@hero78119 hero78119 commented Jun 19, 2026

Copy link
Copy Markdown
Collaborator

Problem

Downstream jagged PCS provers need the assist sumcheck claimed sum in the transcript before running the assist proof. Without an exported helper, callers either recompute the same ROBP-derived value separately or duplicate private jagged internals, which is fragile for GPU/opening integrations.

Approach

Expose assist_sumcheck_prove_and_append_claim so the assist claim is computed, appended, and proved from the same precompute path. Preserve the existing assist_sumcheck_prove API, and keep IOPProverState::claimed_sum() available for frontload sumcheck callers after the first round drops eval(0) from the proof message.

Testing

Validated through downstream integration checks:

  • cargo check -p cuda_hal --features bb31
  • cargo check --features gpu -p ceno_zkvm
  • cargo check -p openvm-reth-benchmark --features gpu

Risk / Rollout

Low protocol risk: the verifier transcript order is unchanged; this only centralizes how the prover computes and appends the existing assist claim. Rollback is to keep callers computing the claim externally and call the original assist prover API.

Copilot Reviewer Directive (keep this section)

When Copilot reviews this PR, apply .github/copilot-instructions.md strictly.

  • Perform review only; do not commit/push/propose code changes.
  • Prefer inline comments on changed lines for each actionable finding.
  • If inline comments are unavailable, use [severity] path:line (symbol) format.
  • Prioritize soundness, performance, and architecture risks over style.
  • Output order: findings by severity, then open questions, then brief summary.
  • If PR description is empty or missing key context, report PR metadata: description as a finding.

@hero78119 hero78119 changed the title fuse jagged assist claim Expose jagged assist claim helper Jun 19, 2026
Comment thread crates/mpcs/src/jagged/assist.rs
@hero78119 hero78119 merged commit 3916c34 into main Jun 22, 2026
2 checks passed
@hero78119 hero78119 deleted the fuse_jagged_assist_claim branch June 22, 2026 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants