Fixed Bucket Assignment#8
Open
raseel-avanse wants to merge 16 commits into
Open
Conversation
Fix bucket assignment
The home page ran its own /api/auth/session check to decide whether to render, while the bucket list is driven by BucketContext -> AuthContext.user (a separate check). When the two resolved out of sync the page rendered with an empty bucket list, and BucketContext had no loading state so an unpopulated list was indistinguishable from a genuinely empty one and never retried. - page.tsx: consume useAuth() instead of a bespoke session fetch, so page gating and data loading share one session resolution (removes a redundant network call). - BucketContext: add isLoading (true until the authenticated user's buckets have been fetched); home page shows a spinner until then instead of flashing an empty list. - e2e: drop the reload() workaround that masked the bug. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
E2E tests for bucket management + AuthContext session race fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.