fix(pagination): stop *_all iterators repeating the first page (SCR-52)#7
Merged
Merged
Conversation
The shared paginate() helper advanced even when the backend returned the same cursor it was given, re-fetching the page just yielded (the 'repeats first page' symptom on search_all and the other *_all iterators). Break when next_cursor is falsy OR equals the cursor we just sent. Bumps 0.15.3 -> 0.15.4.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The shared
paginate()helper (used by every*_alliterator —search_all,get_followers_all,get_user_tweets_all, etc.) advanced even when the backend returned the same cursor it was just given. That re-fetches the page it already yielded — the customer-reported "search_all()repeats the first page" symptom.Fix
Break the loop when
next_cursoris falsy or equals the cursor we just sent:One-line guard at the shared chokepoint — fixes the repeat for all
*_allmethods regardless of which endpoint's backend returns a non-advancing cursor.Test
test_echoed_cursor_stops_iteration— mocks only two pages where page 2 echoes its cursor; a third fetch would raiseStopIteration, so the test fails without the guard. All 14 pagination tests pass; ruff clean.Version
Bumps
0.15.3→0.15.4+ CHANGELOG. (Publish only fires on GitHub release, not on merge.)Closes SCR-52