Skip to content

Tidy the conflict-resolution comment#40

Merged
Phlogistique merged 3 commits into
mainfrom
gloss-conflict-merge-hash
Jun 2, 2026
Merged

Tidy the conflict-resolution comment#40
Phlogistique merged 3 commits into
mainfrom
gloss-conflict-merge-hash

Conversation

@Phlogistique
Copy link
Copy Markdown
Collaborator

@Phlogistique Phlogistique commented Jun 2, 2026

Three polishes to the comment the action posts when a stack update hits conflicts:

  • Gloss the bare commit hash in the git merge step as the target branch as it was just before the merged branch landed, so the user knows what they are merging.
  • Replace git pull origin <branch> with git merge --ff-only origin/<branch>. The preceding git fetch origin already has every ref the steps need, so the pull only fetched the branch a second time.
  • Drop the "I tried to merge ..." opening sentence (and its only helper, format_branch_list_for_text) now that the merge commands carry that context, plus the sub-header it left stranded.

🤖 Generated with Claude Code

Phlogistique and others added 2 commits June 2, 2026 10:08
The resolution steps told the user to `git merge <40-char hash>` with no
hint of what that commit is. Gloss it inline as the target branch as it
was just before the merged branch landed.

Also drops the redundant "I tried to merge ..." header sentence and its
only helper, format_branch_list_for_text: the merge commands now carry
that information.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Dropping the intro paragraph had left two headers back to back. The
warning header now leads straight into a one-line lead-in and the steps.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@Phlogistique Phlogistique marked this pull request as ready for review June 2, 2026 08:11
The resolution steps ran `git fetch origin` and then `git pull origin
<branch>`, which fetches the branch a second time. The standalone fetch
already has every ref the later merges need, so update the local branch
with a local fast-forward to the fetched tip.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@Phlogistique Phlogistique changed the title Explain the commit hash in the conflict-resolution comment Tidy the conflict-resolution comment Jun 2, 2026
@Phlogistique Phlogistique merged commit 9efdf0e into main Jun 2, 2026
2 of 3 checks passed
@github-actions github-actions Bot deleted the gloss-conflict-merge-hash branch June 2, 2026 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant