Document that the e2e suite can and must be run locally or watched in CI#36
Closed
Phlogistique wants to merge 1 commit into
Closed
Document that the e2e suite can and must be run locally or watched in CI#36Phlogistique wants to merge 1 commit into
Phlogistique wants to merge 1 commit into
Conversation
The project CLAUDE.md only named run-e2e-tests.sh without saying it is self-contained, so it kept getting treated as un-runnable and changes shipped "validated by CI later." Spell out that the full e2e runs locally via .claude/run-e2e-tests.sh, that the Tests CI workflow runs the same script on every PR, and that an e2e-touching change is not done until one of the two has actually passed. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Phlogistique
commented
Jun 1, 2026
| bash .claude/run-e2e-tests.sh | ||
| ``` | ||
|
|
||
| This is self-contained: direnv supplies the GitHub App credentials, the script |
Collaborator
Author
There was a problem hiding this comment.
Suggested change
| This is self-contained: direnv supplies the GitHub App credentials, the script | |
| This is self-contained: the environment supplies the GitHub App credentials, the script |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.claude/CLAUDE.mdonly namedrun-e2e-tests.shwithout saying it is self-contained, so the e2e kept getting treated as un-runnable and changes shipped "validated by CI later."Spell out that the full e2e runs locally via
.claude/run-e2e-tests.sh(direnv supplies credentials, throwaway repo), that theTestsCI workflow runs the sametests/test_e2e.shon every PR, and that an e2e-touching change is not done until one of the two has actually passed (with thegh run watchone-liner for the CI path).🤖 Generated with Claude Code