Skip to content

Allow the user to delete the default image.#90

Open
marcosschroh wants to merge 4 commits into
sconsult:masterfrom
marcosschroh:master
Open

Allow the user to delete the default image.#90
marcosschroh wants to merge 4 commits into
sconsult:masterfrom
marcosschroh:master

Conversation

@marcosschroh

Copy link
Copy Markdown

When the plugin is initialized, it has an option to load a default image. if the user wanted to delete the image and upload a new one it was impossible because the preview image will be loaded again, so with this new option, the user can delete the default image, and if he want to restore it, he can clicking in the "Reset Button".

@Ben305

Ben305 commented Apr 14, 2015

Copy link
Copy Markdown

+1

1 similar comment
@drd00m

drd00m commented Apr 14, 2015

Copy link
Copy Markdown

+1

@sconsult

Copy link
Copy Markdown
Owner

Hi @marcosschroh ,

Just got around to check into the pull requests. You have some good points, i will test your code and will merge it with the master if everything works as described.

Thank you for the effort

Mat

@marcosschroh

Copy link
Copy Markdown
Author

Hi, I just want to know if you can check the code. I have added an extra option to set a custom 'Crop button', similar to 'Custom upload button'. You can test this new feature if you want

@txofox

txofox commented Sep 4, 2015

Copy link
Copy Markdown

Hi, I would like to know if the code for Reset button is checked and when it will be merged with master code?

@sconsult

sconsult commented Sep 4, 2015

Copy link
Copy Markdown
Owner

Hi @txofox

Our team will take a look at the implementation if time permits, however the code was not submitted properly and resulted in a 7241 line changes, meaning somebody has to examine the code.

Not that i don't appreciate the effort marcoschroh put in.

As of right now we leave it as a reference but have no resources to check or reintegrate the code.

No

Cheers

Mat

@alpaltunel

Copy link
Copy Markdown

what is the status of this pullrequest? I exactly need this function. If you use loadImage option then its impossible to change it. I need to change image. but how?

@marcosschroh

Copy link
Copy Markdown
Author

Hi @alpaltunel,

You can see the the example in my repo. It's working good.

@sconsult If you want I can to do a new pull request and try to avoid to change a lot of lines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants