scl_source: Support zsh#16
Open
fumiyas wants to merge 1 commit into
Open
Conversation
Contributor
|
I wouldn't be against this - even when TBH I don't actually understand all the zsh-specific shell options. But I don't like the fact this is actually not tested, some zsh-specific test should be added. |
Member
|
@fumiyas Can you please add at least one test which will guarantee that zsh is working properly? |
|
It's been 2 1/2 years. Why doesn't scl support zsh by default anyway? |
Member
|
@shivdhar I know, you would like to have What do you think about it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've created a patch for scl_source to support zsh. Please review it.
Thanks.