[Fix]: fix assertion and error messages in test_correctness_minimal#31
Merged
Merged
Conversation
In SingleNodePolling test, the Get() assertion was inverted: - Get() returns value length (>0) on success, negative error code on failure. The assertion `kv_ret < 0` incorrectly expected failure, causing the test to always fail when Get() succeeds (returns 3072 = data_size). - Fix: `kv_ret < 0` → `kv_ret > 0` - Also fix misleading error message strings for both Put and Get assertions to describe the expected (success) outcome. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
kituro-lin
requested review from
ChillyAokiji,
Sebastian-Keith,
vincent-scitix and
yuki-brook
as code owners
April 15, 2026 03:57
Sebastian-Keith
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In SingleNodePolling test, the Get() assertion was inverted:
kv_ret < 0incorrectly expected failure, causing the test to always fail when Get() succeeds (returns 3072 = data_size).kv_ret < 0→kv_ret > 0