[Fix]: cm handle DEAD-rejoin and STANDBY lifecycle to prevent false reshard triggers#30
Merged
Merged
Conversation
ChillyAokiji
requested review from
Sebastian-Keith,
vincent-scitix and
yuki-brook
as code owners
April 14, 2026 02:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix CM node lifecycle: DEAD rejoin and STANDBY state handling
When a DS restarts after being marked DEAD (i.e., the deferred reshard window had already expired and shards were redistributed), the CM previously set the node back
to RUNNING. This caused two problems:
receiving shards during rebalance despite holding no data.
Fix: introduce a STANDBY state for post-DEAD rejoins. A STANDBY node is tracked but excluded from alive counts and shard rebalance targets. If it goes silent again,
HB timeout transitions it directly to DEAD with no reshard (it holds no shards). A new unit test covers the full RUNNING → DEFERRED_RESHARD → DEAD → STANDBY → DEAD
lifecycle.