[ESSDIFFRACTION] Implement more PDF functions#617
Draft
jl-wynen wants to merge 4 commits into
Draft
Conversation
This matches the convention the scientists want to follow.
github-actions
Bot
changed the title
This only showed up now because the `peaks` module was not included in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #468
Draft because error propagation is missing. But can you take a look anyway because I am unsure about the approach of requiring the user to call a chain of these functions instead of, e.g., always computing the final result from S(r).
I moved the existing implementation to
ess.diffractionbecause it is not directly related to powder.Does this need more tests? The functions are quite simple and tricky to test.