test: add known-issue predicates for #4255 and #4274 to property tests - #4275
Open
TaiSakuma wants to merge 1 commit into
Open
test: add known-issue predicates for #4255 and #4274 to property tests#4275TaiSakuma wants to merge 1 commit into
TaiSakuma wants to merge 1 commit into
Conversation
to property tests Skip the draws affected by the two open conversion defects so the nightly Property Tests report new failures again: - _has_issue_4255 (arrow): an indexed node directly over unknown-type content under option validity crashes from_arrow in remove_optiontype - _has_issue_4274 (arrow, feather) and an inline parquet_writable clause: a root UnmaskedArray of records with a uint32-indexed IndexedArray field crashes to_arrow_table's field projection Each predicate is deleted by the pull request that releases its fix. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
The documentation preview is ready to be viewed at http://preview.awkward-array.org.s3-website.us-east-1.amazonaws.com/PR4275 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The nightly Property Tests workflow has been red since 2026-07-28 on
tests/properties/operations/test_to_from_arrow.py, redrawing two open conversion defects. This adds the known-issue predicates that skip the affected draws, so the nightly reports new defects again while the library fixes proceed separately._has_issue_4255(arrow module): an indexed node directly over unknown-type content, under option validity, crashesak.from_arrowinremove_optiontype(ak.from_arrowfails on an option record with anIndexedArray-of-EmptyArrayfield #4255). The boundary was probed on a clean 2.12.0 install: all four option wrappers trigger it, while an indexed node over a record over unknown does not, so the walker flags only the direct case._has_issue_4274(arrow and feather modules, plus an inlineparquet_writableclause in the parquet module, which keeps its defects inline): a rootUnmaskedArrayof records with a uint32-indexedIndexedArrayfield crashesak.to_arrow_table's field projection (ak.to_arrow_tablefails for anUnmaskedArrayof records with a uint32-indexed field #4274);ak.to_featherandak.to_parquetroute through the same implementation.Each predicate is named after its issue and is meant to be deleted by the pull request that releases the fix, per the module convention.
Verification:
@reproduce_failureblobs from the failing nightly runs (30427564516, 30518689855) reproduce the original crashes against the unmodified modules and are rejected by the filters with these changes.🤖 Generated with Claude Code