Skip to content

fix: migrate to new RDataSource column reader API - #4048

Open
vepadulano wants to merge 9 commits into
scikit-hep:mainfrom
vepadulano:awkward-rdf-fix-source-columnreader
Open

fix: migrate to new RDataSource column reader API#4048
vepadulano wants to merge 9 commits into
scikit-hep:mainfrom
vepadulano:awkward-rdf-fix-source-columnreader

Conversation

@vepadulano

Copy link
Copy Markdown

Change the implementation of the generated RDataSource class to use the newer signature that returns one column reader. This, together with the changes at root-project/root#22234, allow to restore the behaviour that awkward relied upon to store arrays to disk via RDataFrame. Irrespective of these changes, the current in-memory layout of the awkward RecordArray is not fit for storage, leading to writing silently garbage data to disk.

Fixes #3885

Change the implementation of the generated RDataSource class to use the newer signature that returns one column reader. This, together with the changes at root-project/root#22234, allow to restore the behaviour that awkward relied upon to store arrays to disk via RDataFrame. Irrespective of these changes, the current in-memory layout of the awkward RecordArray is not fit for storage, leading to writing silently garbage data to disk.

Fixes scikit-hep#3885
ianna
ianna previously approved these changes May 13, 2026

@ianna ianna left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vepadulano - Thank you so much for providing the fix! As we have discussed at the ROOT hackathon this should fix the Snapshot issue and migrate our implementation to the latest ROOT version. So we are (almost) at the state where we were before. I will schedule the PR for merge for the upcoming release. Thanks!

@ianna ianna added the pr-next-release Required for the next release label May 13, 2026
@codecov

codecov Bot commented May 13, 2026

Copy link
Copy Markdown

⚠️ JUnit XML file not found

The CLI was unable to find any JUnit XML files to upload.
For more help, visit our troubleshooting guide.

@ianna

ianna commented Jun 6, 2026

Copy link
Copy Markdown
Member

@ikrommyd - I’m currently actively coding and pushing changes to this branch to help move it forward. Could you hold off on merging main or making updates to it for now? It’s creating a bit of a moving target for my local setup. I'll make sure it's fully synced up once I'm done with this push.

@TaiSakuma TaiSakuma added the type/fix PR title type: fix (set automatically) label Jun 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-next-release Required for the next release type/fix PR title type: fix (set automatically)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate to ROOT 6.38

4 participants