Fix dark theme contrast and window close bug#7
Merged
Conversation
Replace all system .secondary colors with explicit white.opacity() values for proper visibility on custom dark backgrounds. Replace segmented pickers with custom styled buttons in both GlobeWindowView and StatsView. Fix window close button that failed after opening the stats panel by falling back from keyWindow to mainWindow. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NSApp.keyWindowwas nil when the window lost key status. Now falls back toNSApp.mainWindow..secondarycolor references with explicitColor.white.opacity(X)values in GlobeWindowView and StatsView, since the app uses custom hardcoded dark backgrounds that make adaptive system colors nearly invisible..segmentedpicker style.Changes
GlobeWindowView.swift: Close button fallback, tab bar custom buttons, all.secondary→.white.opacity()StatsView.swift: Period picker custom buttons, all.secondary→.white.opacity(), added missing text colorsTest plan
🤖 Generated with Claude Code