Skip to content

Fix dark theme contrast and window close bug#7

Merged
schlunsen merged 1 commit into
mainfrom
fix/dark-theme-contrast-and-close-bug
Apr 3, 2026
Merged

Fix dark theme contrast and window close bug#7
schlunsen merged 1 commit into
mainfrom
fix/dark-theme-contrast-and-close-bug

Conversation

@schlunsen

Copy link
Copy Markdown
Owner

Summary

  • Fix window close bug: Window could not be closed after opening the Stats panel because NSApp.keyWindow was nil when the window lost key status. Now falls back to NSApp.mainWindow.
  • Fix text contrast on dark backgrounds: Replaced all system .secondary color references with explicit Color.white.opacity(X) values in GlobeWindowView and StatsView, since the app uses custom hardcoded dark backgrounds that make adaptive system colors nearly invisible.
  • Replace segmented pickers with custom buttons: Both the bottom tab bar and the Stats breakdown period picker now use custom styled buttons with proper white-on-dark contrast instead of the system .segmented picker style.

Changes

  • GlobeWindowView.swift: Close button fallback, tab bar custom buttons, all .secondary.white.opacity()
  • StatsView.swift: Period picker custom buttons, all .secondary.white.opacity(), added missing text colors

Test plan

  • Open the Globe window and verify the Servers/Processes/History/Stats tab buttons are clearly visible
  • Click the Stats tab, open the details panel, and verify the close button (red circle) still works
  • Verify Weekly/Monthly toggle in the Breakdown section is readable
  • Verify all text labels (stat cards, period rows, section headers) are visible on the dark background

🤖 Generated with Claude Code

Replace all system .secondary colors with explicit white.opacity() values
for proper visibility on custom dark backgrounds. Replace segmented pickers
with custom styled buttons in both GlobeWindowView and StatsView. Fix
window close button that failed after opening the stats panel by falling
back from keyWindow to mainWindow.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@schlunsen schlunsen merged commit d26b1a9 into main Apr 3, 2026
8 checks passed
@schlunsen schlunsen deleted the fix/dark-theme-contrast-and-close-bug branch April 3, 2026 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant