Skip to content

ci: pass GITHUB_TOKEN to Start cluster step in e2e workflow#149

Merged
scasplte2 merged 2 commits into
scasplte2:mainfrom
ottobot-ai:ci/fix-e2e-snapshot-streaming-token
Jun 11, 2026
Merged

ci: pass GITHUB_TOKEN to Start cluster step in e2e workflow#149
scasplte2 merged 2 commits into
scasplte2:mainfrom
ottobot-ai:ci/fix-e2e-snapshot-streaming-token

Conversation

@ottobot-ai

Copy link
Copy Markdown
Collaborator

Problem

E2E Tests failing across all open PRs with:

RuntimeException: unable to locate a valid GitHub token from
Or(GitConfig(github.token),Environment(GITHUB_TOKEN))

Root Cause

PR #132 removed the pre-staged snapshot-streaming JAR download step, which means just up now builds snapshot-streaming from source. The sbt build for snapshot-streaming resolves dependencies from GitHub Packages, which requires a GitHub token. The Start cluster step didn't have GITHUB_TOKEN in its environment.

Fix

Pass GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} as an env var to the Start cluster step.

Impact

Unblocks E2E on all open PRs: #134, #119, #118, #107, #106, #91

snapshot-streaming is built from source during 'just up', requiring sbt
to resolve dependencies from GitHub Packages. Without GITHUB_TOKEN in
the step environment, sbt fails with:

  RuntimeException: unable to locate a valid GitHub token from
  Or(GitConfig(github.token),Environment(GITHUB_TOKEN))

This regression was introduced in scasplte2#132 (which removed the
pre-staged snapshot-streaming JAR download step). Pass the token
to the Start cluster step to restore E2E functionality.

Fixes all open PRs blocked on this shared E2E failure.
@ottobot-ai

Copy link
Copy Markdown
Collaborator Author

9/10 — Targeted CI fix: passes GITHUB_TOKEN to the Start cluster step so sbt can authenticate to GitHub Packages when building snapshot-streaming from source. Root cause analysis is solid, CODEOWNERS and PR template cleanup are minor housekeeping. Ready to merge.


Iteration 1/5 | Reviewed by CodeBot 🔍

@ottobot-ai ottobot-ai added the tier-2-review Needs human review before merge label Mar 24, 2026
@scasplte2 scasplte2 merged commit 0551a51 into scasplte2:main Jun 11, 2026
5 checks passed
@scasplte2 scasplte2 deleted the ci/fix-e2e-snapshot-streaming-token branch June 11, 2026 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tier-2-review Needs human review before merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants