fix(ci): pass GITHUB_TOKEN to Start cluster step for snapshot-streaming sbt auth

[ottobot-ai]

Problem

All feature branch PRs have been failing E2E since 2026-03-20 with:

error: unable to locate a valid GitHub token from Or(GitConfig(github.token),Environment(GITHUB_TOKEN))

Root Cause

The tessellation develop branch commit abaccd59 ("chore: snapshot streaming tests", 2026-03-19) added a docker/snapshot-streaming/build-snapshot-streaming.sh script that builds snapshot-streaming from source using sbt assembly. This sbt build uses sbt-github-packages to resolve dependencies from GitHub Packages, which requires GITHUB_TOKEN.

The GITHUB_TOKEN is available as an implicit env var in GitHub Actions steps, but it is not automatically forwarded to subprocess shells or scripts invoked via just/compose-runner.sh. Without an explicit env: declaration on the step, the token is unavailable when build-snapshot-streaming.sh invokes sbt.

Docs-only PRs (like #119) pass because they apparently triggered a run before this tessellation commit landed.

Fix

Add env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} to the Start cluster step so that the token is explicitly exported into the subprocess environment.

Impact

Once this merges to main, rebasing all open feature PRs onto main will restore passing E2E for:

• feat/fee-based-data-transactions (feat(fees): add FeeConfig, FeeEstimator, FeeValidator #134)
• feat/token-behavior-scala (feat: add token behavior sealed trait, builder, and proto (16-type TDEG matrix) #118)
• docs/metagraph-integration-analysis (docs: constellation metagraph integration analysis + Phase 1 MPT spec #107)
• docs/ottochain-new-app-skill-spec (docs: ottochain-new-app OpenClaw skill specification #106)
• docs/whitepaper-v2 (docs(whitepaper): v0.4 draft and outline notes #91)

[ottobot-ai]

9/10 — Adds explicit GITHUB_TOKEN env forwarding to the Start cluster step, fixing E2E failures on all feature PRs since 2026-03-20. Correct fix: sbt-github-packages requires the token in the subprocess env, and GHA doesn't auto-forward implicit vars into subshells. Minimal, surgical, well-documented. Ready to merge.

---

Iteration 1/5 | Reviewed by CodeBot 🔍 | SHA: f9d4ffb

[ottobot-ai]

🚨 E2E now failing with a NEW error — upstream snapshot-streaming API incompatibility

Previous issue (GITHUB_TOKEN): Fixed by this PR ✅

New issue: The E2E now fails at sbt assembly for snapshot-streaming with type mismatches in Configuration.scala:

error: type mismatch;
 found   : AddressesConfig
 required: Map[AppEnvironment, SnapshotOrdinal]
(+ 10 more field-shift errors in SharedConfigReader)

Root cause: The E2E workflow clones Constellation-Labs/snapshot-streaming at develop then forces it to compile against tessellation 4.0.0-rc.10 (via sed in build-snapshot-streaming.sh). However, snapshot-streaming's develop branch still targets tessellation 3.2.1-rc.2-179-a2e66401f-SNAPSHOT, which has an incompatible SharedConfigReader API compared to 4.0.0-rc.10.

This affects all PRs equally — it's not specific to this branch.

Suggested fixes (either one):

1. Update Constellation-Labs/snapshot-streaming develop to compile against tessellation 4.0.0-rc.10 (upstream fix)
2. Pin the snapshot-streaming clone to a specific commit/tag that is compatible with 4.0.0-rc.10

@scasplte2 — this needs upstream coordination or a pin in build-snapshot-streaming.sh.

[ottobot-ai]

🔧 Updated fix: download snapshot-streaming JAR from releases

The GITHUB_TOKEN fix was correct but didn't address the root cause. The actual failure is:

Configuration.scala:122:9: type mismatch;
  found   : AddressesConfig
  required: Map[AppEnvironment, SnapshotOrdinal]

Root cause: snapshot-streaming develop branch pins tessellation = "3.2.1-rc.2-179-...-SNAPSHOT". When build-snapshot-streaming.sh overrides this to 4.0.0-rc.10 (to match the running cluster), the Configuration.scala constructor argument order doesn't match the newer tessellation types.

Fix: Pre-stage the snapshot-streaming.jar from GitHub Releases before just up. The build script detects a pre-staged JAR and skips the sbt assembly entirely, bypassing the version incompatibility. Also removes the GITHUB_TOKEN requirement on the Start cluster step since sbt-github-packages auth is no longer needed.

This is a shared CI infrastructure issue affecting all PRs targeting this repo since 2026-03-20 (when tessellation abaccd59 added the snapshot-streaming tests).