Replace use_container_width with width, and pin streamlit - #1
Merged
Conversation
Streamlit renamed this flag and scheduled the old name for removal on 2025-12-31, a date that has already passed. It still works and only logs a warning, but this package declared "streamlit>=1.38.0" with no upper bound, so any future release could drop the old name and stop the score card, radar chart and results tables from rendering. All 3 sites were use_container_width=True on st.plotly_chart or st.dataframe, both of which take width="stretch" as the documented replacement. Found with an AST walk rather than a grep, so a call spanning several lines could not be missed, and st.image was confirmed absent: width there used to mean a pixel count. The floor moves to 1.60.0 because width is not accepted by the older releases the old floor allowed, so swapping the flag without raising it would have broken installs that were previously fine. Capped below 2.0 so a major release cannot silently change widget APIs again. Verified by CI rather than locally: tests/test_dashboard_apptest.py imports resumatch.api, so running it needs the full spacy and sentence-transformers stack, which CI already installs on 3.12 and 3.13.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Streamlit renamed
use_container_widthand scheduled the old name for removal on 2025-12-31, a date that has already passed. It still works and only logs a warning, but this package declaredstreamlit>=1.38.0with no upper bound, so any future release could drop it and stop the score card, radar chart and results tables from rendering.All 3 sites were
use_container_width=Trueonst.plotly_chartorst.dataframe, both of which takewidth="stretch"as the documented replacement. Found with an AST walk rather than a grep, so a call spanning several lines could not be missed, andst.imagewas confirmed absent:widththere used to mean a pixel count.The floor moves to 1.60.0 because
widthis not accepted by the older releases the old floor allowed, so swapping the flag without raising it would have broken installs that were previously fine. Capped below 2.0 so a major release cannot silently change widget APIs again.Verified by CI rather than locally:
tests/test_dashboard_apptest.pyimportsresumatch.api, so running it needs the full spacy and sentence-transformers stack, which CI already installs on 3.12 and 3.13.