renovate: annotate KIND_VERSION and KUBECTL_VERSION in devcontainer#17
Open
vdaviot wants to merge 1 commit into
Open
renovate: annotate KIND_VERSION and KUBECTL_VERSION in devcontainer#17vdaviot wants to merge 1 commit into
vdaviot wants to merge 1 commit into
Conversation
Activates the shared platform-renovate preset's `customManagers:dockerfileVersions` for two ARGs that were previously invisible to Renovate. `extractVersion=^v(?<version>.*)$` strips the leading `v` from upstream release tags so the variable keeps its existing un-prefixed form (the `v` is added back at curl-time in the RUN lines). Once `scality/platform-renovate#3` and `#15` land, Renovate will manage these two pins via the `operator-tooling` group (label `deps/operator-tooling`). Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Annotates
KIND_VERSIONandKUBECTL_VERSIONin.devcontainer/Dockerfileso they're picked up by the new sharedplatform-renovatepreset'scustomManagers:dockerfileVersions. Tracks one of the four follow-ups listed inscality/platform-renovate#3(the in-flight PR comment).Why
scality/crl-operator#15already adds annotations forOPERATOR_SDK_VERSIONandGOLANGCI_VERSIONin the same Dockerfile, butKIND_VERSIONandKUBECTL_VERSIONwere left un-annotated. With the new shared preset (replaces the hand-rolled regex withcustomManagers:dockerfileVersions), this is the small follow-up that makes those two pins visible to Renovate.Annotation choices
KIND_VERSION: trackskubernetes-sigs/kindGitHub releases.extractVersion=^v(?<version>.*)$strips the leadingvso the variable keeps its existing un-prefixed form (thevis added back at curl-time in theRUNline).KUBECTL_VERSION: trackskubernetes/kubernetesGitHub releases (kubectl is part of the main k8s release). SameextractVersionfor the same reason. ThisdepNameis in the new shared preset'soperator-toolinggroup, so updates will be labelleddeps/operator-toolingand grouped with kustomize/controller-tools/operator-sdk.Merge order
This PR depends on the cascade of:
scality/platform-renovate#3— the new shared presetscality/crl-operator#15— the per-repoextendscollapse + the existing OPERATOR_SDK/GOLANGCI annotationsBest to merge in that order. The annotations themselves are inert until both prerequisites land (the
# renovate:comments are simply ignored by Renovate without the matching custom manager active).Test plan
git rebase mainafter the prerequisites land — should auto-merge cleanly (the new annotation lines don't overlap with the OPERATOR_SDK/GOLANGCI annotation lines).kindandkubectlappearing under theoperator-toolinggroup on the Dependency Dashboard.