fix: uri encoding - #3795
Merged
Merged
Conversation
kpodsiad
force-pushed
the
fix/uri-percent-encoding
branch
from
April 5, 2022 20:31
7be48da to
a792218
Compare
kpodsiad
commented
Apr 5, 2022
Comment on lines
+136
to
+137
| else if (value.toUpperCase.startsWith("JAR")) | ||
| URI.create(value).toAbsolutePath(followSymlink) |
Member
Author
There was a problem hiding this comment.
We do not want to overcode JARs, right @Arthurm1?
Contributor
There was a problem hiding this comment.
Good question - I don't think so.
I'm trying to move away from jar URIs in #3750 so that only Metals will deal with jar URIs and only in a few specific classes and the client won't encounter them at all so won't mess with the encoded value.
kpodsiad
force-pushed
the
fix/uri-percent-encoding
branch
from
April 6, 2022 05:59
6ab8d76 to
ac4b748
Compare
kpodsiad
marked this pull request as ready for review
April 6, 2022 08:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #3794