Ignore @throws annotation on non-methods - #26802
Merged
Merged
Conversation
According to JVMS 4.7.9.1 https://docs.oracle.com/javase/specs/jvms/se24/html/jvms-4.html#jvms-4.7.9.1 `ThrowsSignature` is only valid in `MethodSignature`s. Previously, we add `^...` ThrowsSignature no matter the symbol is method or not. We just ignore @throws annotation on invalid locations.
SolalPirelli
approved these changes
Aug 14, 2026
SolalPirelli
left a comment
SolalPirelli
left a comment
Contributor
There was a problem hiding this comment.
Good fix to have for 3.9, but should we error about this earlier in the pipeline? Presumably a developer would do this because they intended to put it somewhere else.
SolalPirelli
added
the
backport:nominated
Member
Author
Yeah, and in fact, Scala 2 already emits error earlier in the pipeline. I'll open an issue 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to JVMS 4.7.9.1
https://docs.oracle.com/javase/specs/jvms/se24/html/jvms-4.html#jvms-4.7.9.1
ThrowsSignatureis only valid inMethodSignatures. Previously, we add^...ThrowsSignature no matter the symbol is method or not. We should just ignore@throwsannotation on invalid locations.Fixes comment by @WojciechMazur #26787 (comment) (in
usql)Have you relied on LLM-based tools in this contribution?
No
How was the solution tested?
New automated tests (including the issue's reproducer, if applicable)