Drop REPL parse warnings on parse error - #26798
Draft
som-snytt wants to merge 4 commits into
Draft
Conversation
som-snytt
force-pushed
the
issue/25055-repl-crosstalk
branch
from
August 13, 2026 18:21
8f480ee to
d601742
Compare
Contributor
Author
|
That is indeed a lot of seconds. |
som-snytt
force-pushed
the
issue/25055-repl-crosstalk
branch
from
August 13, 2026 20:16
d601742 to
4963cb0
Compare
SolalPirelli
approved these changes
Aug 14, 2026
SolalPirelli
left a comment
Contributor
There was a problem hiding this comment.
Nice, and thanks for all the test adjustments!
Contributor
|
(leaving as draft in case you have another change you want to make but feel free to undraft&merge) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #25055
As explained in the comment in Run, REPL does a parse (which may produce diagnostics) and then a compile (which may produce more diagnostics); the parse warnings will be suspended and then moved to the new Run. However, this commit drops those warnings if the parse is erroneous. The errors are issued, and as usual errors have precedence over warnings. Moreover, the warnings are not relevant because the source text must be amended to pass compilation.
The REPL tests are adjusted so that the test text looks the same as a real REPL transcript, where there is a "trailing space" in the prompt but no "leading space" in the diagnostic text. The adjustment makes it easier to paste a transcript to a test.
Have you relied on LLM-based tools in this contribution?
No
How was the solution tested?
New automated tests (including the issue's reproducer, if applicable)