Skip to content

[WIP] feat: toolkit directive follow-up #26792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
warcholjakub wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −1
Draft

[WIP] feat: toolkit directive follow-up #26792

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion repl/src/dotty/tools/repl/ReplDirectives.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,10 @@ private[repl] object ReplDirectives:

def toolkitCoordinates(coords: String): Option[List[String]] =
val flavorAndVersion = coords.split(":", -1).toList match
case version :: Nil if version.nonEmpty => Some((ScalaToolkit.alias, version))
// e.g. //> using toolkit typelevel would otherwise be treated as version `typelevel`
// and fail during resolution with a cryptic error, so we reject it early
case version :: Nil if version.nonEmpty && !toolkitsByFlavor.keySet.contains(version) =>
Some((ScalaToolkit.alias, version))
case flavor :: version :: Nil if flavor.nonEmpty && version.nonEmpty => Some((flavor, version))
case _ => None
flavorAndVersion.map: (flavor, rawVersion) =>
Expand Down
Loading