Remove winget publishing job - #26654
Conversation
Follow up to scala#26595 (review) This PR removes the winget publishing job from the release pipeline. Signed-off-by: Adolfo García Veytia (Puerco) <puerco@carabiner.dev>
|
@WojciechMazur @Gedochao is there a separate ticket about doing something about the rejection from Winget? Have you guys discussed at all whether there's any possibility of finding some way around this? |
Under current implementation - wrapper over scala-cli binary, it seems it won't be accepted as it is identified as script, not a tool/binary. Since there are alternatives available (chocolatey, coursier, direct MSI installer) and lack of real requests risen by the user, I'd say its a low priority with marginal effect on the ecosystem to support WinGet |
|
@WojciechMazur I see. I do wonder about:
since many of the users we care about on this point are not actually Scala users yet. but I admit to not having sufficient basis for a firm opinion |
Pass a specific sbt version to the community Signed-off-by: Adolfo Garcia Veytia (puerco) <puerco@carabiner.dev>
|
I pushed another commit to fix the broken community_build_c which was failing since the previous PR (not related to this change). It pins sbt to 2.0.3 in the community builds because the unpinned version rolled it to 2.0.4. Once we pin the actions this should not happen again. |
|
This seems like a bad idea to me... can we not reuse the existing MSI by serving it via WinGet? It's infinitely more likely to be available on the average Windows machine than Chocolatey or anything else, since WinGet has been built-in for years now |
|
(i.e., if effort is a concern, I think it would be worth it to deprecate choco and even coursier support on Windows in favor of WinGet which is the "standard" thing that just works) |
This PR removes the winget publishing job from the release pipeline as suggested during the review of #26595
Follow up to: #26595 (review)
Have you relied on LLM-based tools in this contribution?
No
How was the solution tested?
This PR removing a job from the pipeline, but here is a test run:
https://github.com/puerco/scala3/actions/runs/30490772451