WIP: Unified IO layer - #26512
Draft
SolalPirelli wants to merge 4 commits into
Draft
Conversation
bishabosha
reviewed
Jul 9, 2026
stasimus
reviewed
Jul 17, 2026
stasimus
reviewed
Jul 17, 2026
stasimus
reviewed
Jul 17, 2026
stasimus
reviewed
Jul 17, 2026
stasimus
reviewed
Jul 17, 2026
SolalPirelli
force-pushed
the
solal/nio
branch
5 times, most recently
from
August 4, 2026 14:30
04eca90 to
8a43af1
Compare
SolalPirelli
force-pushed
the
solal/nio
branch
from
August 10, 2026 13:38
8a43af1 to
0ec36ab
Compare
SolalPirelli
commented
Aug 10, 2026
|
|
||
| override def size(): Long = contents match | ||
| case (s: String, c: Codec) => | ||
| -1 // TODO: remove size() ? |
Contributor
Author
There was a problem hiding this comment.
reminder for myself
SolalPirelli
force-pushed
the
solal/nio
branch
from
August 13, 2026 13:12
0ec36ab to
223838d
Compare
SolalPirelli
force-pushed
the
solal/nio
branch
from
August 14, 2026 11:29
223838d to
14ffa03
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #26492
Adds a new IO package (
nio, which will eventually be renamedio) and replaces all uses ofjava.io,java.nio,dotty.tools.io.AbstractFile, anddotty.tools.io.Pathin the compiler tests with it (except interacting with the compiler and tests for the old IO stuff)The new IO package:
FileandFileContaineras separate typesFilerepresenting the file and then obtain aFileContainerfrom that representing its insides (but they cannot be confused)java.io.Filenorjava.nio.file.Pathat allCodecNo other changes for now.
Have you relied on LLM-based tools in this contribution?
No
How was the solution tested?
Covered by existing tests (this is a refactoring)