Record classfile-derived API for un-loadable Java classes (#837)#1729
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on #1714 (merged). Records an
xsbti.api.ClassLikefor Java classes that can't be reflectively loaded during analysis (#837, sbt/sbt#117), so name-hashing tracks changes to their own public shape — derived directly from the classfile instead of reflection.ClassfileToAPIbuilds a class + moduleClassLikefrom the classfile (members split static/instance), conservatively folding constants, the rawSignature,throws, and annotation types so changes are detected.JavaAnalyzegains areadClassfileAPIcallback (no-op default), wired inAnalyzingJavaCompiler, for the un-loadable fallback path Fix IllegalAccessError analyzing Java compiled with --add-exports (#837) #1714 added.Does not touch loadable classes (still reflection-based). Covered by
ClassfileToAPISpecification/AnalyzeSpecification.