Skip to content

refactor: extract Antimony keywords into AntimonyConstants interface#311

Open
dyrpsf wants to merge 3 commits into
sbmlteam:masterfrom
dyrpsf:chore/antimony-constants
Open

refactor: extract Antimony keywords into AntimonyConstants interface#311
dyrpsf wants to merge 3 commits into
sbmlteam:masterfrom
dyrpsf:chore/antimony-constants

Conversation

@dyrpsf
Copy link
Copy Markdown
Contributor

@dyrpsf dyrpsf commented May 11, 2026

Description

Following up immediately on @draeger's suggestion at the end of #310.

This PR extracts all Antimony-specific keywords, operators, and formatting strings into a centralized AntimonyConstants interface. AntimonySerializer now implements this interface, inheriting the constants directly.

This removes all hardcoded magic strings from the serializer logic, making the parser significantly cleaner and safer to maintain moving forward.

All core tests (AntimonySerializerTest.java) continue to pass cleanly!

@Schmoho
Copy link
Copy Markdown

Schmoho commented May 14, 2026

Here too I would propose to address #313

@dyrpsf
Copy link
Copy Markdown
Contributor Author

dyrpsf commented May 14, 2026

I just pushed AntimonyConstantsTest.java to ensure the interface variables are properly verified against regressions! Let me know if everything looks good to go.

@dyrpsf
Copy link
Copy Markdown
Contributor Author

dyrpsf commented May 15, 2026

Just pushed a quick follow-up commit to add the proper Javadoc and @author tags to the new test file so it perfectly matches the repository's documentation standards!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants