refactor: extract Antimony keywords into AntimonyConstants interface#311
Open
dyrpsf wants to merge 3 commits into
Open
refactor: extract Antimony keywords into AntimonyConstants interface#311dyrpsf wants to merge 3 commits into
dyrpsf wants to merge 3 commits into
Conversation
|
Here too I would propose to address #313 |
Contributor
Author
|
I just pushed |
Contributor
Author
|
Just pushed a quick follow-up commit to add the proper Javadoc and |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Following up immediately on @draeger's suggestion at the end of #310.
This PR extracts all Antimony-specific keywords, operators, and formatting strings into a centralized
AntimonyConstantsinterface.AntimonySerializernow implements this interface, inheriting the constants directly.This removes all hardcoded magic strings from the serializer logic, making the parser significantly cleaner and safer to maintain moving forward.
All core tests (
AntimonySerializerTest.java) continue to pass cleanly!