fix: leak detector with passive scanning.#512
Open
avian2 wants to merge 1 commit into
Open
Conversation
Remove unnecessary check for data (containing service data). Service data is absent in passive scans. Later parsing code only uses mfr_data anyway so this check does not appear necessary. I am not sure why the ckeck was there. The presence of a test suggests that it was intentional as if the sensor did not send valid mfr_data in passive scans and mfr_data should only be parsed in an active scan. However my Switchbot leak detectors (bought July 2025 and April 2026) do send usable battery and leak bits in mfr_data also in passive scans so this check seems unnecessary and prevents me from using parse_advertisement_data in my setup.
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove unnecessary check for data (containing service data). Service data is absent in passive scans. Later parsing code only uses mfr_data anyway so this check does not appear necessary.
I am not sure why the ckeck was there. The presence of a test suggests that it was intentional as if the sensor did not send valid mfr_data in passive scans and mfr_data should only be parsed in an active scan.
However my Switchbot leak detectors (bought July 2025 and April 2026) do send usable battery and leak bits in mfr_data also in passive scans so this check seems unnecessary and prevents me from using parse_advertisement_data in my setup.