Added "Ä" as symbol and also doublequote as symbol as not to confuse printout in graphics mode, changed main program accordingly#1
Open
drkrebs wants to merge 4 commits into
Conversation
print doublequote as symbol, so that it is not confusing the output stream in graphics mode
in synopsis: changed "cdmage" to "cbmtext"
sblendorio
reviewed
May 15, 2021
| char* translate(uint32_t c, char *code) { | ||
| if (isSpace(c)) c = 32; | ||
| if (c >= 32 && c <= 127) { | ||
| if (c !=34 && c >= 32 && c <= 127) { // print doublequote as symbol |
Owner
There was a problem hiding this comment.
There is no need for this exception for chr(34): the definition will be found in the structure and will be used instead of single char, even without modifying the IF statement.
Author
There was a problem hiding this comment.
Thanks! I'm not very experienced in C++.
Change undone, as it wasn't necessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.