Add ReasoningParser#287
Open
junya-takayama wants to merge 6 commits into
Open
Conversation
3827b57 to
9661b17
Compare
Kotaro-Aono
reviewed
May 25, 2026
| ] | ||
| lm_outputs = self._batch_complete_text(chat_messages_as_string, **kwargs) | ||
| if self.reasoning_parser: | ||
| for lm_output in lm_outputs: |
There was a problem hiding this comment.
ここではtoolのところにある
if lm_output.text is None: continue
的な処理はいらないんですかね?
Kotaro-Aono
reviewed
May 25, 2026
| lm_output.text = reasoning.text | ||
| lm_output.reasoning_text = reasoning.reasoning_text | ||
|
|
||
| if self.tool_parser: |
There was a problem hiding this comment.
resoning parserとtool_parserの同時使用って想定されていますか?
想定しているなら下でraw_textとかが上書きされてしまうのでまずい気がします
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a mechanism to the
VLLMandHuggingFaceLMclasses to extract the reasoning content and store it inLMOutput.reasoning_text.Example
flexeval_lm --eval_setup rakuda-v2-ja --language_model VLLM --language_model.model Qwen/Qwen3-4B --language_model.reasoning_parser UnifiedRegexReasoningParser --language_model.reasoning_parser.pattern="<think>(?P<reasoning_content>.*?)</think>(?P<content>.*)"